Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): add special values options for 2.5.0 #381

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Dec 5, 2023

In 2.5.0, the scrapeConfigs options is changed (ref: #344). This adds values changes for upgrade when going from a source version <2.5.0 to a target version >=2.5.0.

Description

Changes:

  • Sets .promtail.config.snippets.scrapeConfigs for upgrade from anywhere in the range 2.0.0-rc.1 - 2.4.0.
  • Changes loki scrapeConfig to use single quotes, because the code here adds double quotes to strings, avoiding bools, null and ints. When double quotes are added to scrapeConfigs, it'll require the double quotes withing the scrapeConfigs to use escapes (\").

@niladrih
Copy link
Member Author

niladrih commented Dec 6, 2023

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit a20622a into develop Dec 6, 2023
8 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the loki branch December 6, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants