Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade changes #358

Merged
merged 4 commits into from
Oct 18, 2023
Merged

feat: upgrade changes #358

merged 4 commits into from
Oct 18, 2023

Conversation

niladrih
Copy link
Member

Changes to upgrade.

Description

Changes:

  1. upgrade-job now does not use the semver::VersionReq API. Instead uses lt, gt, ge, le, eq operators to judge order of version. This is because VersionReq doesn't accurately reflect order when comparing stable versions with pre-release ones (https://internals.rust-lang.org/t/changing-cargo-semver-compatibility-for-pre-releases/14820/9).
  2. Add pre-flight check failure in the kubectl-mayastor plugin when a stable version tries to upgrade to an unstable one. This can be avoided with the --allow-unstable flag. The existing flag --skip-upgrade-path-validation-for-unsupported-version also skips this check.
  3. Add pre-flight check failure in the kubectl-mayastor plugin when the source version is higher (semver) than the target.
  4. Avoid running the publish_chart_yaml.sh script for v2.5.0-0-main-unstable-<timestamp>-0 alongside the usual tag 2.5.0-0-main-unstable-<timestamp>-0.

k8s/upgrade/src/plugin/preflight_validations.rs Outdated Show resolved Hide resolved
k8s/upgrade/src/plugin/upgrade.rs Outdated Show resolved Hide resolved
k8s/upgrade/src/plugin/upgrade.rs Show resolved Hide resolved
k8s/upgrade/src/bin/upgrade-job/helm/values.rs Outdated Show resolved Hide resolved
@niladrih niladrih force-pushed the upgrade-repotags-fix branch from 3c561bb to e954b4e Compare October 16, 2023 17:19
@niladrih
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 18, 2023
358: feat: upgrade changes r=niladrih a=niladrih

<!

Co-authored-by: Niladri Halder <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 18, 2023

This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried.

Additional information:

Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@niladrih
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 18, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 1eb3701 into develop Oct 18, 2023
4 checks passed
@bors bors bot deleted the upgrade-repotags-fix branch October 18, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants