-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for testing 'upgrade' from develop branch #341
Conversation
71b88c7
to
bb949df
Compare
bors try |
tryBuild failed: |
bb949df
to
59f7032
Compare
bors try |
tryBuild failed: |
59f7032
to
d862502
Compare
bors try |
tryBuild failed: |
d862502
to
979e969
Compare
bors cancel |
bors try |
tryBuild failed: |
979e969
to
de47149
Compare
bors cancel |
bors try |
bors cancel |
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
6888a66
to
7db825b
Compare
7db825b
to
2de0b9e
Compare
2de0b9e
to
9d15088
Compare
9d15088
to
ae4e728
Compare
Signed-off-by: Niladri Halder <[email protected]>
ae4e728
to
85e3c05
Compare
85e3c05
to
b26af52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the github action, and publish helm chart sections of the PR
bors merge |
341: Changes for testing 'upgrade' from develop branch r=niladrih a=niladrih <! Co-authored-by: Niladri Halder <[email protected]>
…ranch Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
b26af52
to
d1ec228
Compare
Canceled. |
bors merge |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Upgrade e2e tests are run as a part of release/x.y branches, but not develop or main. This change modifies the chart that is posted to the 'main' branch, and this chart should qualify as a valid target helm chart for upgrade, thus allowing testing code from develop (main branch uses code from develop at a set frequency).
The intention is to be able to upgrade from a released version to develop or main.
Description
Changes to upgrade code:
image.repoTags
instead ofimage.tag
.Changes to publish_chart_yaml.sh script:
--develop-to-main
flag) from0.0.0-main
to the likes of2.5.0-0-develop-unstable-2023-09-24-19-55-15-0
, where 2.5.0 is semver minor bump from the latest possible release (based on existing release/x.y branches on openebs/mayastor-extensions), and 2023-09-24-19-55-15 is a timestamp generated from the commanddate +%Y-%m-%d-%H-%M-%S
.--latest-release-branch <branch_name>
option. The default value is generated from git remote refs from the git repo. To use the default branch-name generation, all refs from the remote repo openebs/mayastor-extensions must be pulled in (e.g.git fetch origin
where origin is the remote entry for the openebs/mayastor-extensions repo)--bump-major-for-main
bumps the major version instead, if and when the version bump needs to be a major one.GitHub Actions changes:
-main
suffix will no longer have any use) and the charts will be hosted on the https://github.com/openebs/mayastor-chart-donotuse repo.--check-chart
to run a basic sanity test, like the one for the develop-chart actions workflow.This change adds two major use cases for the publish_chart_yaml.sh script:
./scripts/helm/publish_chart_yaml.sh --check-chart main
. This is minor use-case, This does not do a good job of validating the chart version/appVersion, etc.Tested manually.