fix(upgrade-job): set defaults for absent helm values #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niladri Halder <[email protected]>
avishnu
approved these changes
Sep 4, 2023
niladrih
requested review from
sinhaashish,
Abhinandan-Purkait,
w3aman and
abhilashshetty04
|
bors merge |
sinhaashish
approved these changes
Sep 4, 2023
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
338: Cherry-pick #337 to release/2.4 branch r=niladrih a=niladrih <! Co-authored-by: Niladri Halder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade-job parses few specific values from the source mayastor helm chart's values.yaml. These are used to make conditional value 'sets'. Usually these values would always be available in the target helm chart, but it may be absent in the source helm chart (as it may have been added during later releases). It has to assume sane defaults for these values, so that the parse operation does not fail for the source helm chart.
Description
This PR sets default values for 'csi.image.snapshotterTag', 'csi.image.snapshotControllerTag' and 'eventing.enabled'.
N.B.:
These default values are not used in the final values set used with the helm upgrade. They are simply used to conveniently make decisions about 'special' yq set operations (e.g. changed default values, etc.). Values yaml for upgrade is generated using yq.