fix(upgrade-job): avoid quotes when setting yaml bools, null, int #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
avishnu,
sinhaashish,
Abhinandan-Purkait,
datacore-vvarakantham and
abhilashshetty04
avishnu
approved these changes
Aug 29, 2023
niladrih
changed the title
I think we could make it look prettier, with better syntax. Functionally, we should be good. We could simplify by giving each of these types their own set function -- IMO this is unnecessary. WDYT @tiagolobocastro? |
Signed-off-by: Niladri Halder <[email protected]>
sinhaashish
approved these changes
Aug 29, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
335: Cherry-pick PR #334 to release/2.4 branch r=niladrih a=niladrih This PR cherry-picks the commits from the following PRs to release/2.4 branch: - #334 Co-authored-by: Niladri Halder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a the case when yq sets a value other than a string on to a yaml file (i.e. a bool or a null). This removes the
"character surrounding the set value when the value set is 'true', 'false', an int or 'null'.Description
This upgrade-job needs to be idempotent. The job may restart, and it has to be able to avoid repeating itself. The yq_set_string_value() method sets values with
""surrounding the values. This works well with the other set values that the helm::values module uses, however, witheventing.enabled, the value that is expected is a bool, but the yq_set_string_value() method's quotes sets it as a string. The first helm upgrade run (without restarts), works fine, as helm is able to derive the bool value out of the string. However, the helm::chart module expects theeventing.enabledkey to have a value of type bool.This change in the this PR, matches the boolean values 'true' and 'false' to decide if it should avoid using
""around the value before setting it. This change also handles the cases for 'null' and integer values.How Has This Been Tested?
Tested manually using a kubeadm cluster.