Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(upgrade): modify check for rebuilding #299

Closed
wants to merge 1 commit into from

Conversation

sinhaashish
Copy link
Member

No description provided.

@abhilashshetty04
Copy link
Contributor

abhilashshetty04 commented Jul 26, 2023

@sinhaashish, Lets add nexus state validation before cordoning the node. Not necessary to list all nexuses in cluster. Only nexuses of the node about to be cordoned is fine. Since rebuild_wait doesnt account for Faulted state we might switchover nexus and trigger unnecessary Full rebuild.

@tiagolobocastro @avishnu , During every node upgrade, wait_for_rebuild lists all volumes and checks rebuild_progress in all childs. This will not return if any child has rebuild_progress. I think we should wait even if child is Faulted as eventually same or different child will rebuild if Faulted and then we will have rebuild_pregress populated. It might happen on the next node upgrade.

@sinhaashish
Copy link
Member Author

Closing this PR as a consolidated #314 is raised to resolve this issue.

@sinhaashish sinhaashish deleted the modify-rebuilding branch August 21, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants