fix(supportability/loki): add missing newlines #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Jun 26, 2023
tiagolobocastro
commented
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait and
niladrih
Abhinandan-Purkait
approved these changes
Jun 27, 2023
It's not entirely clear how this was even working before, but this should work going forward. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
loki-newlines
branch
from
ea4b0f9 to
ee0e68b
Compare
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
loki-newlines
branch
from
ee0e68b to
e76a3ef
Compare
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
tiagolobocastro
added a commit
that referenced
this pull request
Jun 27, 2023
265: fix(supportability/loki): add missing newlines r=tiagolobocastro a=tiagolobocastro
feat(supportability/loki): add loki dump subcommand
Signed-off-by: Tiago Castro <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
268: Cherry-pick pull request #265 r=tiagolobocastro a=tiagolobocastro 265: fix(supportability/loki): add missing newlines r=tiagolobocastro a=tiagolobocastro feat(supportability/loki): add loki dump subcommand Signed-off-by: Tiago Castro <[email protected]> Co-authored-by: mayastor-bors <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.