fix(upgrade-job): upgrade path validation and set flags #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
sinhaashish and
Abhinandan-Purkait
instead of 2.1.x releases Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
|
why is this required |
niladrih
force-pushed
the
fix-upgrade-from-2.1
branch
from
e5beaec to
78e75f1
Compare
Signed-off-by: Niladri Halder <[email protected]>
Oh, that's not supposted to be there.. |
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
niladrih
changed the title
sinhaashish
approved these changes
May 22, 2023
tiagolobocastro
approved these changes
May 22, 2023
Signed-off-by: Niladri Halder <[email protected]>
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
that referenced
this pull request
May 22, 2023
244: Cherry-pick the commits from PR #242 to release/2.2 branch r=niladrih a=niladrih This PR includes the commits from the following PR(s): - #242 Co-authored-by: Niladri Halder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--setflags to set thin provisioning flags for 2.0.x releases, instead of 2.1.x release.--skip-upgrade-path-validationflag. This is not necessary for the openebs/openebs (Umbrella) chart because this upgrade-job does not support upgrade for the openebs chart, so might as well move that check to be a Core chart exclusive check.--setflags for 2.0.x release to be used with future 2.0.x releases as well, and not just till 2.0.1.