fix(upgrade-job): refactor version check #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
niladrih
commented
May 17, 2023
•
niladrih
commented
- add failure case for when the source version is newer than the target version
- remove redundant check for 'already_upgraded' case: currently the invalid versions are explicitly listed in an input YAML file, thus there need not be an additional exclusion case here, as we do not list the current version in the invalid-versions-file
- add failure case for when the source version is newer than the target version - remove redundant check for 'already_upgraded' case: currently the invalid versions are explicitly listed in an input YAML file, thus there need not be an additional exclusion case here, as we do no list the current version in the invalid-versions-file Signed-off-by: Niladri Halder <[email protected]>
|
bors try |
tiagolobocastro
approved these changes
May 17, 2023
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Abhinandan-Purkait
approved these changes
May 17, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
that referenced
this pull request
May 18, 2023
239: Cherry-pick #238 to release/2.2 branch r=niladrih a=niladrih Co-authored-by: Niladri Halder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.