chore(bors): merge pull request #397

397: fix(upgrade-job): avoid infinite loop when no unhealthy vols have a target r=niladrih a=niladrih Fixes a bug where if, during data-plane upgrade, `rebuild_result` function finds unhealthy volumes, but none of the volumes have a target, then, the function continues to try to list unhealthy volumes constantly. <! Co-authored-by: Niladri Halder <[email protected]>
openebs · Dec 27, 2023 · b86947c · b86947c
2 parents 2a93380 + c0096f6
commit b86947c
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/k8s/upgrade/src/bin/upgrade-job/upgrade/utils.rs b/k8s/upgrade/src/bin/upgrade-job/upgrade/utils.rs
@@ -33,14 +33,13 @@ pub(crate) async fn rebuild_result(
             break;
         }
 
+        let mut volume_over_nodes = HashSet::new();
         for volume in unhealthy_volumes.iter() {
-            let target = if let Some(target) = volume.state.target.as_ref() {
-                target
-            } else {
-                continue;
+            let target = match volume.state.target.as_ref() {
+                Some(t) => t,
+                None => continue,
             };
 
-            let mut volume_over_nodes = HashSet::new();
             volume_over_nodes.insert(target.node.as_str());
 
             for (_, topology) in volume.state.replica_topology.iter() {
@@ -74,6 +73,9 @@ pub(crate) async fn rebuild_result(
                 }
             }
         }
+        if volume_over_nodes.is_empty() {
+            break;
+        }
     }
     Ok(RebuildResult {
         rebuilding: false,