Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: specify opentel receiver endpoint #874

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

tiagolobocastro
Copy link
Contributor

When running on the CI we an opentel receiver to push the traces to an external collector.
With recent versions of the receiver, it now listens only on localhost which was prevent it from receiving the traces to begin with. Now we specify the domain name of the receiver.

When running on the CI we an opentel receiver to push the traces to
an external collector.
With recent versions of the receiver, it now listens only on localhost
which was prevent it from receiving the traces to begin with.
Now we specify the domain name of the receiver.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro
Copy link
Contributor Author

This fixes the flaky rest client test :)

@tiagolobocastro
Copy link
Contributor Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 10, 2024
874: ci: specify opentel receiver endpoint r=tiagolobocastro a=tiagolobocastro

When running on the CI we an opentel receiver to push the traces to an external collector.
With recent versions of the receiver, it now listens only on localhost which was prevent it from receiving the traces to begin with. Now we specify the domain name of the receiver.

Co-authored-by: Tiago Castro <[email protected]>
@tiagolobocastro
Copy link
Contributor Author

bors cancel

@bors-openebs-mayastor
Copy link

Canceled.

Also made the fields pub.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 10, 2024
874: ci: specify opentel receiver endpoint r=tiagolobocastro a=tiagolobocastro

When running on the CI we an opentel receiver to push the traces to an external collector.
With recent versions of the receiver, it now listens only on localhost which was prevent it from receiving the traces to begin with. Now we specify the domain name of the receiver.

Co-authored-by: Tiago Castro <[email protected]>
@bors-openebs-mayastor
Copy link

Build failed:

@tiagolobocastro
Copy link
Contributor Author

Operation not permitted: '/tmp/disk_0'

😮
Probably previous cancel killed the test without cleanup? I guess we need to ensure final cleanup does clean everything up, maybe using a specific folder within tmp to make it easier to cleanup, example: one single rm -rf /tmp/ci-run-99

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 934be63 into develop Oct 10, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the test-jaeger branch October 10, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants