Blocking nvme disconnect fixes #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Mar 7, 2024
tiagolobocastro
commented
Dependent nvmeadm crate is blocking and certain operations such as disconnecting the controller can take quite some time. Here we are just doing a WA by running the disconnect in a tokio blocking spawn. todo: Ideally we should either make nvmeadm async or somehow provide async as alternative, which won't be great as the code will likely get duplicated... Signed-off-by: Tiago Castro <[email protected]>
In a system test run we've seen the disconnect of an old path take 50s to complete. We're not sure why this is the case as we cannot reproduce it yet but for now we can increase the timeout. This is probably fine as if we can't talk to the node where the app is then we can't do much more anyway. We should also consider wether we need to wait for the disconnect at all. If we can find out if the disconnect has been started, then we can probably just complete that async and succeed the replace! Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
dsavitskiy,
sinhaashish,
Abhinandan-Purkait,
niladrih and
abhilashshetty04
tiagolobocastro
changed the title
Abhinandan-Purkait
approved these changes
Mar 8, 2024
Signed-off-by: Tiago Castro <[email protected]>
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.