-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use pagination to load values from pstor #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors try |
tryBuild succeeded: |
Abhinandan-Purkait
force-pushed
the
pstor_pagination
branch
from
February 12, 2024 14:01
b57f549
to
8dc2b1c
Compare
bors try |
tryBuild failed: |
tiagolobocastro
approved these changes
Feb 12, 2024
control-plane/agents/src/bin/core/controller/resources/migration.rs
Outdated
Show resolved
Hide resolved
bors try |
tryBuild failed: |
Abhinandan-Purkait
force-pushed
the
pstor_pagination
branch
from
February 13, 2024 07:43
915f980
to
30503bc
Compare
bors try |
tryBuild succeeded: |
Abhinandan-Purkait
force-pushed
the
pstor_pagination
branch
from
February 13, 2024 10:45
30503bc
to
54de1bd
Compare
bors try |
tryBuild succeeded: |
Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
pstor_pagination
branch
from
February 13, 2024 12:43
54de1bd
to
2a7c025
Compare
bors merge |
Build succeeded: |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
753: cherry-pick: #737 to use pstor pagination r=Abhinandan-Purkait a=Abhinandan-Purkait ### Changes in the PR. - Changes the spec population from etcd from non paged call to a paged call. - Also incorporates the pagination to legacy migration flows. Co-authored-by: Abhinandan Purkait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the PR.