build(utils/version): add correct git HEAD paths #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this is used a dependency for extensions the build.rs for utils-lib ends up adding an invalid git path to the cargo re-runs. This actually causes continuous rebuilding on the extensions repo. Fixes this by ensure the path exists and by checking specifically for the extensions env var. The latter one is, to put it bluntly, a hack, but atm I don't know else to do it in a quick way. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
Abhinandan-Purkait,
niladrih,
datacore-vvarakantham and
abhilashshetty04
Abhinandan-Purkait
approved these changes
Jan 22, 2024
sinhaashish
approved these changes
Jan 22, 2024
|
bors merge |
niladrih
approved these changes
Jan 22, 2024
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
719: build(utils/version): add correct git HEAD paths r=tiagolobocastro a=tiagolobocastro When this is used a dependency for extensions the build.rs for utils-lib ends up adding an invalid git path to the cargo re-runs. This actually causes continuous rebuilding on the extensions repo. Fixes this by ensure the path exists and by checking specifically for the extensions env var. The latter one is, to put it bluntly, a hack, but atm I don't know else to do it in a quick way. Co-authored-by: Tiago Castro <[email protected]>
|
bors cancel |
|
Canceled. |
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
fix-rebuild
branch
from
eac9a9c to
e81151b
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is used a dependency for extensions the build.rs for utils-lib ends up adding an invalid git path to the cargo re-runs. This actually causes continuous rebuilding on the extensions repo. Fixes this by ensure the path exists and by checking specifically for the extensions env var.
The latter one is, to put it bluntly, a hack, but atm I don't know else to do it in a quick way.