refactor: replica listing based on query #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
rep_type
branch
from
0469cbc to
40f08a6
Compare
tiagolobocastro
approved these changes
Aug 24, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
666: refactor: replica listing based on query r=Abhinandan-Purkait a=Abhinandan-Purkait ### What does this PR do? - Refactors the replica list by query feature. ### Why do we need this PR? - This simplifies the query and increases maintainability. Co-authored-by: Abhinandan Purkait <[email protected]>
|
bors cancel |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
666: refactor: replica listing based on query r=Abhinandan-Purkait a=Abhinandan-Purkait ### What does this PR do? - Refactors the replica list by query feature. ### Why do we need this PR? - This simplifies the query and increases maintainability. Co-authored-by: Abhinandan Purkait <[email protected]>
|
bors cancel |
|
Canceled. |
Signed-off-by: Tiago Castro <[email protected]>
|
bors merge |
|
bors cancel |
|
Canceled. |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
667: Cherry pick #666 #664 #665 r=tiagolobocastro a=Abhinandan-Purkait Co-authored-by: Abhinandan Purkait <[email protected]> Co-authored-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why do we need this PR?