feat(snapshots, restores): store restores as a part of snap meta, expose counts on rest #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Abhinandan-Purkait
commented
Aug 9, 2023
•
Abhinandan-Purkait
commented
Abhinandan-Purkait
force-pushed
the
restore_count
branch
from
e69498a to
28aad38
Compare
tiagolobocastro
approved these changes
Aug 10, 2023
Abhinandan-Purkait
force-pushed
the
restore_count
branch
from
f15265d to
8c8f7dd
Compare
|
bors try |
tryBuild failed: |
tryTimed out. |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
656: feat(snapshots, restores): store restores as a part of snap meta, expose counts on rest r=Abhinandan-Purkait a=Abhinandan-Purkait ``` rest-plugin get volumes ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da26 1 <none> <none> Online 10MiB true (snapped) 12MiB 1 <none> ec4e66fd-3b33-4439-b504-d49aba53da27 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ec4e66fd-3b33-4439-b504-d49aba53da28 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ``` ``` rest-plugin get volumes --source none ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da26 1 <none> <none> Online 10MiB true (snapped) 12MiB 1 <none> ``` ``` rest-plugin get volumes --source snapshot ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da27 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ec4e66fd-3b33-4439-b504-d49aba53da28 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ``` Co-authored-by: Abhinandan Purkait <[email protected]>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
656: feat(snapshots, restores): store restores as a part of snap meta, expose counts on rest r=Abhinandan-Purkait a=Abhinandan-Purkait ``` rest-plugin get volumes ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da26 1 <none> <none> Online 10MiB true (snapped) 12MiB 1 <none> ec4e66fd-3b33-4439-b504-d49aba53da27 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ec4e66fd-3b33-4439-b504-d49aba53da28 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ``` ``` rest-plugin get volumes --source none ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da26 1 <none> <none> Online 10MiB true (snapped) 12MiB 1 <none> ``` ``` rest-plugin get volumes --source snapshot ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da27 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ec4e66fd-3b33-4439-b504-d49aba53da28 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ``` Co-authored-by: Abhinandan Purkait <[email protected]>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
656: feat(snapshots, restores): store restores as a part of snap meta, expose counts on rest r=Abhinandan-Purkait a=Abhinandan-Purkait ``` rest-plugin get volumes ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da26 1 <none> <none> Online 10MiB true (snapped) 12MiB 1 <none> ec4e66fd-3b33-4439-b504-d49aba53da27 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ec4e66fd-3b33-4439-b504-d49aba53da28 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ``` ``` rest-plugin get volumes --source none ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da26 1 <none> <none> Online 10MiB true (snapped) 12MiB 1 <none> ``` ``` rest-plugin get volumes --source snapshot ID REPLICAS TARGET-NODE ACCESSIBILITY STATUS SIZE THIN-PROVISIONED ALLOCATED SNAPSHOTS SOURCE ec4e66fd-3b33-4439-b504-d49aba53da27 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ec4e66fd-3b33-4439-b504-d49aba53da28 1 <none> <none> Online 10MiB true 12MiB 0 Snapshot ``` Co-authored-by: Abhinandan Purkait <[email protected]>
|
Build failed: |
Abhinandan-Purkait
force-pushed
the
restore_count
branch
from
8af99f2 to
501c534
Compare
…ose counts on rest Signed-off-by: Abhinandan Purkait <[email protected]>
…estore count Signed-off-by: Abhinandan Purkait <[email protected]>
Signed-off-by: Abhinandan Purkait <[email protected]>
Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
restore_count
branch
from
501c534 to
f7de9fb
Compare
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.