feat(snapshots): add garbage collector to cleanup leaked snapshots unknown to control-plane #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
control-plane/agents/src/bin/core/controller/reconciler/node/snapshot.rs
Outdated
Show resolved
Hide resolved
control-plane/agents/src/bin/core/controller/reconciler/node/snapshot.rs
Outdated
Show resolved
Hide resolved
control-plane/agents/src/bin/core/controller/reconciler/node/snapshot.rs
Outdated
Show resolved
Hide resolved
Abhinandan-Purkait
force-pushed
the
unknown_snap_gc
branch
3 times, most recently
from
8bb2fd7 to
f340438
Compare
tiagolobocastro
approved these changes
Aug 7, 2023
control-plane/agents/src/bin/core/controller/reconciler/node/snapshot.rs
Outdated
Show resolved
Hide resolved
control-plane/agents/src/bin/core/controller/reconciler/node/snapshot.rs
Outdated
Show resolved
Hide resolved
Abhinandan-Purkait
force-pushed
the
unknown_snap_gc
branch
from
f340438 to
241822a
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
655: feat(snapshots): add garbage collector to cleanup leaked snapshots unknown to control-plane r=Abhinandan-Purkait a=Abhinandan-Purkait Co-authored-by: Abhinandan Purkait <[email protected]>
|
Build failed: |
tiagolobocastro
requested changes
Aug 7, 2023
control-plane/agents/src/bin/core/controller/reconciler/node/snapshot.rs
Outdated
Show resolved
Hide resolved
Abhinandan-Purkait
force-pushed
the
unknown_snap_gc
branch
from
241822a to
a5ac83f
Compare
|
bors try |
tiagolobocastro
approved these changes
Aug 7, 2023
control-plane/agents/src/bin/core/controller/reconciler/node/snapshot.rs
Outdated
Show resolved
Hide resolved
tryBuild failed: |
…known to control-plane Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
unknown_snap_gc
branch
from
a5ac83f to
97bc965
Compare
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.