Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clone): enable option for fs id change to clone uuid #650

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Abhinandan-Purkait
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait commented Jul 26, 2023

  • cloneFsIdAsVolumeId -- Parameter to enable changing the filesystem uuid to clone uuid to tackle duplicate id issue on xfs.
  • If Parameter is not enabled nouuid to be used as a default behaviour.

@Abhinandan-Purkait Abhinandan-Purkait force-pushed the fs-id-change branch 3 times, most recently from ead92e5 to aeee095 Compare August 1, 2023 11:37
@Abhinandan-Purkait Abhinandan-Purkait changed the title feat(clone): pass 'nouuid' as an default mount option for clones feat(clone): enable option for fs id change to clone uuid Aug 2, 2023
Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If we are going to change volume clone to volume restore, do we need a change in the code like variable names, function names, file names, etc?
If yes, we can still do those changes in a new PR.

@Abhinandan-Purkait
Copy link
Member Author

LGTM. If we are going to change volume clone to volume restore, do we need a change in the code like variable names, function names, file names, etc? If yes, we can still do those changes in a new PR.

Yes, I will change them to the restore.

control-plane/csi-driver/src/bin/node/filesystem_vol.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/controller/controller.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/controller/controller.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/filesystem_vol.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/format.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/format.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/context.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/context.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/filesystem.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/filesystem.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/filesystem_ops.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/filesystem_ops.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/filesystem_ops.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/filesystem_ops.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/filesystem_ops.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/filesystem_ops.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/format.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/mount.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/context.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/context.rs Outdated Show resolved Hide resolved
@Abhinandan-Purkait Abhinandan-Purkait force-pushed the fs-id-change branch 2 times, most recently from f3e6662 to 19132ef Compare August 3, 2023 10:09
control-plane/csi-driver/src/bin/node/filesystem_ops.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/filesystem_ops.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/format.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/format.rs Outdated Show resolved Hide resolved
@Abhinandan-Purkait
Copy link
Member Author

bors merge

@bors
Copy link

bors bot commented Aug 3, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 5b9c495 into develop Aug 3, 2023
@bors bors bot deleted the fs-id-change branch August 3, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants