-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clone): enable option for fs id change to clone uuid #650
Conversation
f81f155
to
42c98fb
Compare
ead92e5
to
aeee095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If we are going to change volume clone to volume restore, do we need a change in the code like variable names, function names, file names, etc?
If yes, we can still do those changes in a new PR.
Yes, I will change them to the |
d8271c9
to
2a1f03c
Compare
f3e6662
to
19132ef
Compare
19132ef
to
de7d0ab
Compare
Signed-off-by: Abhinandan Purkait <[email protected]>
de7d0ab
to
2c7d81e
Compare
bors merge |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
cloneFsIdAsVolumeId
-- Parameter to enable changing the filesystem uuid to clone uuid to tackle duplicate id issue on xfs.nouuid
to be used as a default behaviour.