Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cordon-drain): return correct updated spec #621

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

tiagolobocastro
Copy link
Contributor

Outdated spec was being returned as part of the cordon/drain operations.

Copy link
Contributor

@chriswldenyer chriswldenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors
Copy link

bors bot commented Jul 5, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit de03e11 into develop Jul 5, 2023
bors bot pushed a commit that referenced this pull request Jul 5, 2023
622: Cherry-pick #621 r=tiagolobocastro a=tiagolobocastro

fix(cordon-drain): return correct updated spec

Outdated spec was being returned as part of the cordon/drain operations.

Co-authored-by: Tiago Castro <[email protected]>
@bors bors bot deleted the node-changes branch July 5, 2023 09:40
bors bot pushed a commit that referenced this pull request Jul 11, 2023
631: fix: ensure the updated node spec is used in drain r=chriswldenyer a=chriswldenyer

Additional changes similar to those in #621


Co-authored-by: chriswldenyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants