Volume Snapshot Commitment #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Jul 5, 2023
tiagolobocastro
commented
Make cache reload period too high so we don't try to refresh whilst testing a timeout condition. Signed-off-by: Tiago Castro <[email protected]>
Abhinandan-Purkait
approved these changes
Jul 5, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
619: Volume Snapshot Commitment r=tiagolobocastro a=tiagolobocastro
feat(snapshot/commitment): use commitment when creating a snapshot
The snapshot create now uses the same rules as volume/replica creation.
Signed-off-by: Tiago Castro <[email protected]>
---
ci: fix test race condition
Make cache reload period too high so we don't try to refresh whilst testing
a timeout condition.
Signed-off-by: Tiago Castro <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
|
Build failed: |
bors bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
620: Cherry-pick #619 r=tiagolobocastro a=tiagolobocastro feat(snapshot/commitment): use commitment when creating a snapshot The snapshot create now uses the same rules as volume/replica creation. Signed-off-by: Tiago Castro <[email protected]> --- ci: fix test race condition Make cache reload period too high so we don't try to refresh whilst testing a timeout condition. Signed-off-by: Tiago Castro <[email protected]> Co-authored-by: Tiago Castro <[email protected]>
The snapshot create now uses the same rules as volume/replica creation. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
snapshot/thin
branch
from
4ff1569 to
c4c236f
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
619: Volume Snapshot Commitment r=tiagolobocastro a=tiagolobocastro
feat(snapshot/commitment): use commitment when creating a snapshot
The snapshot create now uses the same rules as volume/replica creation.
Signed-off-by: Tiago Castro <[email protected]>
---
ci: fix test race condition
Make cache reload period too high so we don't try to refresh whilst testing
a timeout condition.
Signed-off-by: Tiago Castro <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"Required status check \"DCO\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
620: Cherry-pick #619 r=tiagolobocastro a=tiagolobocastro feat(snapshot/commitment): use commitment when creating a snapshot The snapshot create now uses the same rules as volume/replica creation. Signed-off-by: Tiago Castro <[email protected]> --- ci: fix test race condition Make cache reload period too high so we don't try to refresh whilst testing a timeout condition. Signed-off-by: Tiago Castro <[email protected]> Co-authored-by: Tiago Castro <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
620: Cherry-pick #619 r=tiagolobocastro a=tiagolobocastro feat(snapshot/commitment): use commitment when creating a snapshot The snapshot create now uses the same rules as volume/replica creation. Signed-off-by: Tiago Castro <[email protected]> --- ci: fix test race condition Make cache reload period too high so we don't try to refresh whilst testing a timeout condition. Signed-off-by: Tiago Castro <[email protected]> Co-authored-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.