chore: add garbage collector for cleaning in creating snapshots with no transactions #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
changed the title
control-plane/agents/src/bin/core/controller/reconciler/snapshot/garbage_collector.rs
Outdated
Show resolved
Hide resolved
control-plane/agents/src/bin/core/controller/reconciler/snapshot/garbage_collector.rs
Show resolved
Hide resolved
Abhinandan-Purkait
force-pushed
the
cleanup_reconciler
branch
4 times, most recently
from
7401473 to
dbe8741
Compare
tiagolobocastro
approved these changes
Jul 3, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
608: chore: add garbage collector for cleaning in creating snapshots with no transactions r=Abhinandan-Purkait a=Abhinandan-Purkait Co-authored-by: Abhinandan Purkait <[email protected]>
|
Build failed: |
Abhinandan-Purkait
force-pushed
the
cleanup_reconciler
branch
from
dbe8741 to
f5181f5
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
608: chore: add garbage collector for cleaning in creating snapshots with no transactions r=Abhinandan-Purkait a=Abhinandan-Purkait Co-authored-by: Abhinandan Purkait <[email protected]>
|
bors cancel |
|
Canceled. |
Abhinandan-Purkait
force-pushed
the
cleanup_reconciler
branch
3 times, most recently
from
1bbeecb to
bb03a71
Compare
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Abhinandan-Purkait
force-pushed
the
cleanup_reconciler
branch
2 times, most recently
from
5cbd19e to
96be00f
Compare
|
bors try |
tiagolobocastro
approved these changes
Jul 3, 2023
control-plane/agents/src/bin/core/volume/snapshot_operations.rs
Outdated
Show resolved
Hide resolved
tryBuild failed: |
Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
cleanup_reconciler
branch
from
96be00f to
fdf6453
Compare
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
613: Cherry-pick #608 r=Abhinandan-Purkait a=Abhinandan-Purkait fix(snapshot): garbage collect creating snapshots with no transactions Co-authored-by: Abhinandan Purkait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.