Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nexus_cleanup): cleanup old nexuses post volume destroy #549

Merged
merged 1 commit into from
May 25, 2023
Merged

fix(nexus_cleanup): cleanup old nexuses post volume destroy #549

merged 1 commit into from
May 25, 2023

Conversation

abhilashshetty04
Copy link
Contributor

With this PR we set lazy as true when creating DestroyNexus. This sets NexusStatus as Deleting which allows reconciler to handle deletion if initial attempt fails for some reason.

@abhilashshetty04
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request May 25, 2023
Try #549:
44b291c
@bors
Copy link

bors bot commented May 25, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@abhilashshetty04
Copy link
Contributor Author

bors merge

@bors
Copy link

bors bot commented May 25, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@abhilashshetty04
Copy link
Contributor Author

bors cancel

@bors
Copy link

bors bot commented May 25, 2023

Canceled.

@abhilashshetty04
Copy link
Contributor Author

bors merge

@bors
Copy link

bors bot commented May 25, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link

bors bot commented May 25, 2023

Canceled.

@abhilashshetty04
Copy link
Contributor Author

bors merge

@abhilashshetty04 abhilashshetty04 mentioned this pull request May 25, 2023
Merged
@bors
Copy link

bors bot commented May 25, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 45b07b7 into develop May 25, 2023
@bors bors bot deleted the nexus_cleanup branch May 25, 2023 14:16
bors bot pushed a commit that referenced this pull request May 25, 2023
@abhilashshetty04
chore(bors): merge pull request #553
b5194cb 
553: fix(nexus_cleanup): cleanup old nexuses post volume destroy r=abhilashshetty04 a=abhilashshetty04

develop PR:
#549

Co-authored-by: Abhilash Shetty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@chriswldenyer chriswldenyer Awaiting requested review from chriswldenyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhilashshetty04 @tiagolobocastro @Abhinandan-Purkait