-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several Switchover fixes #503
Conversation
tiagolobocastro
commented
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Few nits.
bors merge |
503: Several Switchover fixes r=tiagolobocastro a=tiagolobocastro test(switchover/bdd): add robustness tests Add tests to help exercise some corner cases seen during bug study. Tbh these are not very precise as it's difficult to re-create some corner cases, but nonetheless they are probably a decent starting point and can be used to help manually try to recreate these issues in a more automated fashion. Signed-off-by: Tiago Castro <[email protected]> Co-authored-by: Tiago Castro <[email protected]>
Build failed: |
On the deployer the udev code we have for listening to disk events does not seem to work. For now, assume it is incompatible and add a subsystem sync just for platform none. Signed-off-by: Tiago Castro <[email protected]>
Newer version (not sure which exactly) seems to generate the test cases without a name. todo: determine best version to use Signed-off-by: Tiago Castro <[email protected]>
Replace path is not idempotent in case the connection was established without moving path. gRPC Timeouts for connection are not enough which leads into moving the target when not necessary. Report of failed paths does not differentiate errors at all. Report of failed paths returns only 1 error.. we should have an error per path as we report. in batches. In case of no resources for republish volume the ha cluster retries in a loop with no delay. or backoff.. In error case we don’t clean up shutdown targets. On switchover failure, failed paths are not cleared in the cluster agent. Signed-off-by: Tiago Castro <[email protected]>
Add tests to help exercise some corner cases seen during bug study. Tbh these are not very precise as it's difficult to re-create some corner cases, but nonetheless they are probably a decent starting point and can be used to help manually try to recreate these issues in a more automated fashion. Signed-off-by: Tiago Castro <[email protected]>
bors merge |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |