Skip to content

Commit

Permalink
fix: code-review comments
Browse files Browse the repository at this point in the history
Signed-off-by: chriswldenyer <[email protected]>
  • Loading branch information
chriswldenyer committed Jan 9, 2024
1 parent 06643fb commit ca5da39
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion control-plane/agents/src/common/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ pub enum SvcError {
DrainNotAllowedWhenHAisDisabled {},
#[snafu(display("Target switchover is not allowed without HA"))]
SwitchoverNotAllowedWhenHAisDisabled {},
#[snafu(display("The volume would exceed the capacity"))]
#[snafu(display("The volume would exceed the capacity limit"))]
VolWouldExceedCapacity {},
}

Expand Down
6 changes: 3 additions & 3 deletions tests/bdd/features/volume/capacity_limit/creation.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@ Feature: Volume creation capacity limit
Background:
Given a control plane, Io-Engine instances and a pool

Scenario: attempted creation exceeding the capacity limit
Scenario: attempted volume creation exceeding the capacity limit
Given a gRPC request to create a volume
When the request includes a capacity limit
And the volume creation would result in the capacity limit being exceeded
Then volume creation should fail with an out-of-range error

Scenario: attempted creation within the capacity limit
Scenario: attempted volume creation within the capacity limit
Given a gRPC request to create a volume
When the request includes a capacity limit
And the volume creation would not result in the capacity limit being exceeded
Then volume creation should succeed

Scenario: attempted creation with no capacity limit
Scenario: attempted volume creation with no capacity limit
Given a gRPC request to create a volume
When the request does not include a capacity limit
Then volume creation should succeed
Expand Down

0 comments on commit ca5da39

Please sign in to comment.