Fix travis build process #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why this PR does ?** This PR will fix the build issue in travis. Now travis will buils mayactl as well as maya-apiserver binaries and if build is tagged by github it will release and deploy them in Github relaeas pages.
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 19.86% 19.86%
=======================================
Files 58 58
Lines 7419 7419
=======================================
Hits 1474 1474
Misses 5838 5838
Partials 107 107Continue to review full report at Codecov.
|
GNUmakefile
Outdated
| @@ -23,7 +23,7 @@ APISERVER=maya-apiserver | |||
| # Specify the date o build | |||
| BUILD_DATE = $(shell date +'%Y%m%d%H%M%S') | |||
|
|
|||
| all: test | |||
| all: test bin apiserver | |||
There was a problem hiding this comment.
Can the target bin be renamed to mayactl or something more appropriate ?
There was a problem hiding this comment.
Naming it as mayactl
| @@ -28,15 +28,15 @@ XC_OSS=(${XC_OS// / }) | |||
|
|
|||
| # Delete the old dir | |||
| echo "==> Removing old directory..." | |||
| rm -rf bin/* | |||
| mkdir -p bin/ | |||
| rm -rf bin/maya/* | |||
There was a problem hiding this comment.
Will it be good to move this file to buildscripts/mayactl ?
|
Done !! |
GNUmakefile
Outdated
| @echo "----------------------------" | ||
| @echo "--> maya " | ||
| @echo "----------------------------" | ||
| @MAYACTL=${MAYACTL} sh -c "'$(PWD)/buildscripts/build.sh'" | ||
| @MAYACTL=${MAYACTL} sh -c "'$(PWD)/buildscripts/ctl/build.sh'" |
There was a problem hiding this comment.
well why ctl ? & why not mayactl ?
Changing to buildscript/mayactl dir as a naming convention follows is a repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR will fix the build issue in travis. Now travis will build mayactl as well as maya-apiserver
binaries and if this is tagged by github it will release and deploy them in Github release pages
fixes openebs/openebs#599
fixes openebs/openebs#597