-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list_snap): LIST_SNAP uzfs ioctl implementation #49
Conversation
Signed-off-by: Vitta <[email protected]>
…tsnap Signed-off-by: Vitta <[email protected]>
Related PR to this in cstor: mayadata-io/cstor#295 |
Signed-off-by: Vitta <[email protected]>
Signed-off-by: Vitta <[email protected]>
Signed-off-by: Vitta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the PR description with updated sample JSON output?
Ok it was updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked more at usability angle and changes are good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Signed-off-by: Vitta <[email protected]>
Signed-off-by: Vitta <[email protected]>
Signed-off-by: Vitta <[email protected]>
Signed-off-by: Vitta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
merged this, travis the failing as there is dependency on mayadata-io/cstor#295. |
This PR adds the LIST_SNAP uzfs ioctl implementation.
For command
zfs listsnap <dataset>
, output will be in json format as:This will NOT list the snapshots created through 'zfs snapshot' until the zrepl is restarted. However, it lists the snapshots created through istgt iscsi target.
This command implementation reads the snapshot list from disk once and caches the list. This cache will be updated with snapshot name for every SNAP_CREATE command from istgt. This cache will be served for every trigger of this ioctl.
Working on testcases.