Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Typos #29

Merged
merged 4 commits into from
Nov 26, 2019
Merged

Fixed Typos #29

merged 4 commits into from
Nov 26, 2019

Conversation

AyushBherwani1998
Copy link
Contributor

No description provided.

pawanpraka1
pawanpraka1 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Can you pull the latest changes and update the pull request.

@pawanpraka1
Copy link
Contributor

pawanpraka1 commented Oct 9, 2019 •
edited
Loading

also can you DCO signoff the commit.

Sign your work
We use the Developer Certificate of Origin (DCO) as an additional safeguard for the OpenEBS project. This is a well established and widely used mechanism to assure that contributors have confirmed their right to license their contribution under the project's license. Please read dcofile. If you can certify it, then just add a line to every git commit message:

  Signed-off-by: Random J Developer <[email protected]>
Use your real name (sorry, no pseudonyms or anonymous contributions). The email id should match the email id provided in your GitHub profile. If you set your user.name and user.email in git config, you can sign your commit automatically with git commit -s.

You can also use git aliases like git config --global alias.ci 'commit -s'. Now you can commit with git ci and the commit will be signed.

vishnuitta
vishnuitta reviewed Oct 10, 2019
View reviewed changes
README.md Outdated
@@ -1,9 +1,9 @@
# libcstor
# Libcstor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better to small case itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the appropriate changes

@vishnuitta
Copy link
Contributor

Needs DCO signoff

@AyushBherwani1998
Copy link
Contributor Author

AyushBherwani1998 commented Oct 28, 2019 •
edited
Loading

Needs DCO signoff

I have signed the DCO

@kmova kmova merged commit 2e5a5b2 into openebs-archive:master Nov 26, 2019
@NisantaSahoo
Copy link

Thanks for taking part in Hacktoberfest 2019. Please fill up this form to claim your swag https://hubs.ly/H0l5ldm0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmova kmova kmova approved these changes

@vishnuitta vishnuitta Awaiting requested review from vishnuitta

@pawanpraka1 pawanpraka1 Awaiting requested review from pawanpraka1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AyushBherwani1998 @pawanpraka1 @vishnuitta @NisantaSahoo @kmova