Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a fourth tool that provides insight into adding drainage #88

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Adds a fourth tool that provides insight into adding drainage #88

wants to merge 10 commits into from

Conversation

bazottie
Copy link
Collaborator

@bazottie bazottie commented Dec 11, 2024 •
edited
Loading

Requires a new endpoint which is not yet available

@bazottie bazottie self-assigned this Dec 11, 2024
@bazottie bazottie changed the title Adds a fourth tool that allows for changing drainage levels Adds a fourth tool that provides insight into adding drainage Dec 19, 2024
@bazottie bazottie marked this pull request as ready for review January 7, 2025 13:36
sjoerdbeentjes
sjoerdbeentjes requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@sjoerdbeentjes sjoerdbeentjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some small comments, looks good ✨

src/components/drainage-configuration-form.vue Outdated Show resolved Hide resolved
src/lib/get-drainage-data.js Outdated Show resolved Hide resolved
@bazottie bazottie mentioned this pull request Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoerdbeentjes sjoerdbeentjes sjoerdbeentjes requested changes

Assignees

@bazottie bazottie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bazottie @sjoerdbeentjes