Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pip output #234

Merged
merged 30 commits into from
Feb 18, 2025
Merged

Cleanup pip output #234

merged 30 commits into from
Feb 18, 2025

Conversation

mccalluc
Copy link
Contributor

Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, the pip install output is cleaned up, but the first page of the PDF is left blank after the install command, which looks a little strange. Is it possible to remove the blank lines after the install command?

@mccalluc
Copy link
Contributor Author

Let me download again: I though that without that output block the wrapping wasn't as bad, but the script block is also large, and it might not be able to break that up either. I'll check.

Base automatically changed from 55-pdf-export to main February 14, 2025 23:34
@mccalluc
Copy link
Contributor Author

Switching from "classic" to "lab" template fixed the page break issue. Also make some other tweaks for readability.

Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved 👍

@mccalluc mccalluc merged commit 02c8970 into main Feb 18, 2025
2 checks passed
@mccalluc mccalluc deleted the 230-cleanup-pip-output branch February 18, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Clean up pip install outputs cell
2 participants