Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add support for ODFE 1.6(Elasticsearch v7.6.1) #38

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

rguo-aws
Copy link
Contributor

Issue #, if available:

Description of changes:
Add support for ODFE 1.6(Elasticsearch v7.6.1)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rguo-aws rguo-aws requested review from ditac and ktkrg March 11, 2020 19:45
@@ -20,11 +20,11 @@ plugins {

node {
version = "10.15.0"
download = true
download = false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was due to some download failure I came across when trying to download this version of node js. Will revert this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact, this is caused by a known issue in gradle 6.0:
srs/gradle-node-plugin#351

So I have to disable node js download to get rid of the download failure

@rguo-aws rguo-aws merged commit 2000bfb into opendistro-1.6 Mar 17, 2020
@rguo-aws rguo-aws deleted the rguo-odfe-1.6 branch March 17, 2020 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants