This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve Test coverage #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
=============================================
+ Coverage 19.47% 31.77% +12.30%
- Complexity 80 116 +36
=============================================
Files 39 39
Lines 2008 2008
Branches 150 150
=============================================
+ Hits 391 638 +247
+ Misses 1598 1335 -263
- Partials 19 35 +16
Continue to review full report at Codecov.
|
yu-sun-77
force-pushed
the
test-coverage
branch
from
a9d9667
to
7bbf006
Compare
ktkrg
reviewed
Dec 3, 2020
...mazon/opendistro/elasticsearch/performanceanalyzer/collectors/NodeDetailsCollectorTests.java
Outdated
Show resolved
Hide resolved
...mazon/opendistro/elasticsearch/performanceanalyzer/collectors/NodeDetailsCollectorTests.java
Outdated
Show resolved
Hide resolved
.../elasticsearch/performanceanalyzer/collectors/NodeStatsFixedShardsMetricsCollectorTests.java
Outdated
Show resolved
Hide resolved
.../elasticsearch/performanceanalyzer/collectors/NodeStatsFixedShardsMetricsCollectorTests.java
Outdated
Show resolved
Hide resolved
yu-sun-77
force-pushed
the
test-coverage
branch
3 times, most recently
from
ed2438c
to
7eea5eb
Compare
adityaj1107
approved these changes
Dec 4, 2020
| threadPool.shutdownNow(); | ||
| super.tearDown(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we add saveMetricsValues test here as well?
| @Test | ||
| public void testCollectMetrics() { | ||
| createIndex(TEST_INDEX); | ||
| Mockito.when(controller.getNodeStatsShardsPerCollection()).thenReturn(1); |
There was a problem hiding this comment.
Should we add a test to check if all the metrics for all the shards are populated in subsequent runs of this collector?
| public void tearDown() throws Exception { | ||
| super.tearDown(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we add saveMetricsValues test here as well?
| CacheMaxSizeStatus filedDataCache = metrics.get(0); | ||
| CacheMaxSizeStatus shardRequestCache = metrics.get(1); | ||
| assertEquals(CacheType.FIELD_DATA_CACHE.toString(), filedDataCache.getCacheType()); | ||
| assertEquals(CacheType.SHARD_REQUEST_CACHE.toString(), shardRequestCache.getCacheType()); |
There was a problem hiding this comment.
Should we assert values for Cache Sizes as well?
ktkrg
approved these changes
Dec 5, 2020
| @@ -0,0 +1,66 @@ | |||
| package com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors; | |||
| @@ -0,0 +1,80 @@ | |||
| package com.amazon.opendistro.elasticsearch.performanceanalyzer.collectors; | |||
|
created #253 to track missing license headers for new files. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #, if available:
Description of changes:
Improve Test coverage from 19% to 40%
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.