This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Bad File Descriptor error due to double VirtualMachineImpl$SocketInputStream.close #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing double close properly, which will fail in cases like try (BufferedReader br = new BufferedReader( ((HotSpotVirtualMachine) vm).remoteDataDump((Object[]) args));). Fix is: avoiding double close from client side to avoid Bad file descriptor errors
ditac
approved these changes
Mar 18, 2019
yeajung
approved these changes
Mar 18, 2019
aesgithub
reviewed
Mar 19, 2019
src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/jvm/ThreadList.java
Show resolved
Hide resolved
aesgithub
approved these changes
Mar 19, 2019
This was referenced Apr 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sun.tools.attach.VirtualMachineImpl$SocketInputStream.close not handling double close properly, which will fail in cases like try (BufferedReader br = new BufferedReader( ((HotSpotVirtualMachine) vm).remoteDataDump((Object[]) args));). Fix is: avoiding double close from client side to avoid Bad file descriptor errors
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.