This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Add In-Context Reporting Menu #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
requested review from
seraphjiang,
mihirsoni,
akbhatta and
zhongnansu
seraphjiang
reviewed
Sep 25, 2020
kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx
Outdated
Show resolved
Hide resolved
seraphjiang
reviewed
Sep 25, 2020
kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx
Outdated
Show resolved
Hide resolved
seraphjiang
reviewed
Sep 25, 2020
kibana-reports/public/components/report_definitions/create/create_report_definition.tsx
Outdated
Show resolved
Hide resolved
seraphjiang
reviewed
Sep 25, 2020
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| export const getMenuItem = (name) => { |
There was a problem hiding this comment.
no need to change, but consider convert to react component in the future
seraphjiang
reviewed
Sep 25, 2020
kibana-reports/public/components/context_menu/context_menu_helpers.js
Outdated
Show resolved
Hide resolved
seraphjiang
reviewed
Sep 25, 2020
seraphjiang
reviewed
Sep 25, 2020
seraphjiang
reviewed
Sep 25, 2020
seraphjiang
reviewed
Sep 25, 2020
seraphjiang
reviewed
Sep 25, 2020
seraphjiang
reviewed
Sep 25, 2020
seraphjiang
approved these changes
Sep 29, 2020
akbhatta
approved these changes
Sep 29, 2020
mihirsoni
reviewed
Sep 30, 2020
| @@ -3,6 +3,7 @@ | |||
| "version": "0.0.1", | |||
| "kibanaVersion": "7.8.0", | |||
| "requiredPlugins": ["navigation"], | |||
| "optionalPlugins": ["share"], | |||
| @@ -0,0 +1,230 @@ | |||
| /* | |||
| @@ -28,6 +28,7 @@ import { ReportSettings } from '../report_settings'; | |||
| import { ReportDelivery } from '../delivery'; | |||
| import { ReportTrigger } from '../report_trigger'; | |||
| import { generateReport } from '../../main/main_utils'; | |||
| import { Request } from 'selenium-webdriver/http'; | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Added in-context reporting menu in
DashboardsandVisualizationspagesList of Changes:
Reportingmenu in the navigation menuReport sourceandTime rangepre-selected after navigation toCreate report definitionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.