This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
[UI] Align UI to the schema & API refactor - table and detail page #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
seraphjiang,
joshuali925,
akbhatta and
davidcui1225
akbhatta
approved these changes
Sep 15, 2020
| deliveryChannels: data['delivery']['channel'], | ||
| kibanaRecipients: data['delivery']['delivery_params']['recipients'], | ||
| status: reportDefinition.status, | ||
| deliveryChannels: `\u2014`, |
There was a problem hiding this comment.
nit: may be also refactor \u2014 (can be in another PR as well)
davidcui1225
approved these changes
Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Apply schema & API changes to UI - table and detail page
Link the newly-added
generate report by idAPI to enable the click-on icon downloadLinked snapshot of dashboard/visualization to the report source field. It will open an new tab
remove unused imports, optimize the table data access logic.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.