This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Add Routes for Get Visualizations & Saved Search #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbhatta
approved these changes
Aug 20, 2020
server/routes/getVisualizations.ts
Outdated
| }; | ||
| try { | ||
| const esResp = await context.core.elasticsearch.legacy.client.callAsInternalUser( | ||
| 'search', |
There was a problem hiding this comment.
is it required to be 'search' here?
server/routes/getVisualizations.ts
Outdated
| size: 10000, | ||
| }; | ||
| try { | ||
| const esResp = await context.core.elasticsearch.legacy.client.callAsInternalUser( |
There was a problem hiding this comment.
may be use full string like esResponse?
server/routes/getVisualizations.ts
Outdated
| async ( | ||
| context, | ||
| request, | ||
| response |
There was a problem hiding this comment.
this seems to be output param, if so may be use outResponse?
zhongnansu
reviewed
Aug 20, 2020
zhongnansu
approved these changes
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add routes to get list of visualizations and saved searches for user to select from when creating a report definition.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.