This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Connect Report Details Backend #52
Merged
davidcui1225
merged 8 commits into
opendistro-for-elasticsearch:dev
from
davidcui1225:report-details-backend-connect
Aug 14, 2020
Merged
Connect Report Details Backend #52
davidcui1225
merged 8 commits into
opendistro-for-elasticsearch:dev
from
davidcui1225:report-details-backend-connect
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
requested review from
seraphjiang,
mihirsoni,
joshuali925 and
zhongnansu
July 29, 2020 19:05
joshuali925
reviewed
Jul 29, 2020
mihirsoni
reviewed
Aug 3, 2020
zhongnansu
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments before merge
joshuali925
approved these changes
Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Connect Report Details API to front-end to provide actual Report details for each report in Reports table.
Note
: Depends on #51TODO
: Update data model/schema for Report details to return more information that's listed in the Report details pageBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.