Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Fix pdf/png report generation for hashed page url #371

Merged

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented May 20, 2021

Issue #, if available:
#343
Description of changes:

  • make use of unhash() from kibanaUtils to handle page url
  • imcrease some test case timeout
  • formatting some code

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhongnansu zhongnansu changed the title Fix pdf/png report generation for hasned page url Fix pdf/png report generation for hashed page url May 20, 2021
@zhongnansu zhongnansu requested review from davidcui1225 and joshuali925 and removed request for davidcui1225 May 20, 2021 17:11
@zhongnansu zhongnansu marked this pull request as ready for review May 20, 2021 17:11
@zhongnansu zhongnansu added the need migrate need migrate to OpenSearch label May 20, 2021
@zhongnansu zhongnansu merged commit 702cd2b into opendistro-for-elasticsearch:dev May 21, 2021
@zhongnansu zhongnansu removed the need migrate need migrate to OpenSearch label Jun 8, 2021
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Jul 1, 2021
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants