-
Notifications
You must be signed in to change notification settings - Fork 31
add global tenant for report definition urls #324
add global tenant for report definition urls #324
Conversation
if (tenant === '__user__') { | ||
if (tenant !== undefined) { | ||
if (tenant === '') { | ||
tenant = 'global'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the user creates a new tenant with name "global"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then after this if else check, tenant
variable will be assigned with global
. It will be added to the url without any issue. Same for global tenant. they follow the same format in the url ?security_tenant=global
or ?security_tenant=<customized_tenant_name>
. From the actual behavior point, it's out of our control. Not sure seucirty plugin has a way to distinguish that.
Codecov Report
@@ Coverage Diff @@
## dev #324 +/- ##
============================================
- Coverage 64.07% 64.04% -0.04%
Complexity 291 291
============================================
Files 100 100
Lines 4064 4066 +2
Branches 618 619 +1
============================================
Hits 2604 2604
- Misses 1300 1302 +2
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Issue #, if available:
on-demand report definition still renders the tenant panel
Description of changes:
add condtion to check global tenant and add to url
TODO:
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.