This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Backport Context Menu fix to 7.9.1 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
requested review from
anirudha,
joshuali925,
akbhatta,
zhongnansu and
abbashus
Codecov Report
@@ Coverage Diff @@
## 7.9.1 #300 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 32 32
Lines 1809 1809
Branches 357 357
=======================================
Hits 1320 1320
Misses 484 484
Partials 5 5 Continue to review full report at Codecov.
|
joshuali925
approved these changes
Jan 9, 2021
zhongnansu
reviewed
Jan 10, 2021
| @@ -142,7 +142,7 @@ export const popoverMenuDiscover = (savedObjectAvailable) => { | |||
| </div> | |||
| <div data-focus-lock-disabled="disabled"> | |||
| <div class="euiPanel euiPopover__panel euiPopover__panel--bottom euiPopover__panel-isOpen euiPopover__panel-withTitle" aria-live="assertive" role="dialog" aria-modal="true" aria-describedby="i199c7fc0-f92e-11ea-a40d-395bfe9dc89a" style="top: 97px; left: 255.583px; z-index: 2000;" id="reportPopover"> | |||
| <div class="euiPopover__panelArrow euiPopover__panelArrow--bottom" style="left: 15.9417px; top: 0px;"> | |||
| <div class="euiPopover__panelArrow euiPopover__panelArrow--bottom" style="left: 30.9417px; top: 0px;"> | |||
There was a problem hiding this comment.
Is this necessary? I didn't see this change in your PR to dev
There was a problem hiding this comment.
Yeah- in 7.9.1 the Discover reporting menu was not lined up over the Reporting nav menu item, it's almost not under it at all.
akbhatta
approved these changes
Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
DiscoverpageRelated: #299
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.