Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Context menu popout & Report definitions Toast fixes #295

Conversation

davidcui1225
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:

  • Download in progress modal disappears after any response is received, so it will not remain on-screen after operation is done in error cases
  • Commented out report definition toasts since we don't display the report definitions table

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhongnansu
Copy link
Member

Do you confirm that we are not calling the reportDefinition/listAll API when we are on the landing page? (not sure if it's the correct naming, lol)

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #295 (132c54c) into 7.9.1 (31249c9) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            7.9.1     #295      +/-   ##
==========================================
+ Coverage   72.85%   72.89%   +0.03%     
==========================================
  Files          32       32              
  Lines        1809     1804       -5     
  Branches      357      357              
==========================================
- Hits         1318     1315       -3     
+ Misses        486      484       -2     
  Partials        5        5              
Impacted Files Coverage Δ
kibana-reports/public/components/main/main.tsx 48.91% <ø> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31249c9...132c54c. Read the comment docs.

@davidcui1225
Copy link
Contributor Author

Do you confirm that we are not calling the reportDefinition/listAll API when we are on the landing page? (not sure if it's the correct naming, lol)

Yes, I think you are referring to the GET ../api/reporting/reportDefinitions API which is only called once within a helper function refreshReportDefinitionsTableContent that is no longer used anywhere in main

@anirudha anirudha merged commit fc032a6 into opendistro-for-elasticsearch:7.9.1 Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants