This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Fix reporting download button visibility issue for dashboard and visualization #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
davidcui1225,
joshuali925,
akbhatta and
penghuo
Codecov Report
@@ Coverage Diff @@
## dev #294 +/- ##
=======================================
Coverage 77.61% 77.61%
=======================================
Files 32 32
Lines 1800 1800
Branches 356 356
=======================================
Hits 1397 1397
Misses 398 398
Partials 5 5 Continue to review full report at Codecov.
|
davidcui1225
approved these changes
Jan 8, 2021
joshuali925
approved these changes
Jan 8, 2021
zhongnansu
added a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Jan 8, 2021
…alization (opendistro-for-elasticsearch#294) * fix reporting download button visibility issue * update height px * update height px
zhongnansu
added a commit
that referenced
this pull request
Jan 8, 2021
…alization (#294) * fix reporting download button visibility issue * update height px * update height px
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
For creating a new dashboard or visualization, the reporting download button should be disabled. Currently it's enabled and of course it leads to error download report, becuase the saved object hasn't been created yet
Description of changes:
Somehow discover page doesn't have this issue, so I copied the logic of in-context menu from Discover to apply.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.