Change Reports Table Display #291
Conversation
… in report source field
davidcui1225
requested review from
joshuali925,
akbhatta,
zhongnansu and
abbashus
|
Is this 7.9.1 specific feature? Do we need to push any changes to |
Codecov Report
@@ Coverage Diff @@
## 7.9.1 #291 +/- ##
=======================================
Coverage 72.85% 72.85%
=======================================
Files 32 32
Lines 1809 1809
Branches 357 357
=======================================
Hits 1318 1318
Misses 486 486
Partials 5 5
Continue to review full report at Codecov.
|
No, this issue is not present in |
| reportSource: reportParams.report_name.substring( | ||
| 0, reportParams.report_name.lastIndexOf('_') | ||
| ), // remove uuid from report name to display report source | ||
| reportSource: reportParams.description, // display report source name |
There was a problem hiding this comment.
Is this a typo? We are assigning description to the source field
There was a problem hiding this comment.
Not a typo- we need a place to store the raw report source name without parsing out any special characters. And the description field is not used anywhere else.
Issue #, if available:
Description of changes:
Report IDcolumn now displays<ReportSourceType>_<UUID>, e.gDashboard_abcdefghijk123descriptioncolumn in schema now contains the Report source name to be displayed in theReport sourcefieldReports tablenow prompts user to search bySourcein addition to Report IDBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.