This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Add semaphore to block on puppeteer chromium execution #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
reviewed
Jan 5, 2021
|
Do we have the UT/IT to cover the change? |
Codecov Report
@@ Coverage Diff @@
## dev #284 +/- ##
==========================================
+ Coverage 74.94% 75.14% +0.19%
==========================================
Files 32 32
Lines 1764 1766 +2
Branches 342 345 +3
==========================================
+ Hits 1322 1327 +5
+ Misses 437 434 -3
Partials 5 5
Continue to review full report at Codecov.
|
akbhatta
reviewed
Jan 5, 2021
kibana-reports/server/plugin.ts
Outdated
|
|
||
| constructor(initializerContext: PluginInitializerContext) { | ||
| this.logger = initializerContext.logger.get(); | ||
| this.semaphore = withTimeout(new Semaphore(1), 30000, new Error('timeout')); |
There was a problem hiding this comment.
I think 30 sec is too less a timeout. may be 180 seconds?
There was a problem hiding this comment.
changed to 180 seconds
akbhatta
approved these changes
Jan 6, 2021
zhongnansu
approved these changes
Jan 6, 2021
penghuo
reviewed
Jan 6, 2021
| } else if (error.body.statusCode === 503) { | ||
| handleErrorToast( | ||
| 'Error generating report.', | ||
| `Timed out generating report ID ${reportId}. Try again later.` |
There was a problem hiding this comment.
does 503 always because of timeout?
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Jan 6, 2021
…r-elasticsearch#284) * Add mutex to lock on creating report using puppeteer * Use semaphore instead of mutex * change semaphore limit to 1 * Add 30 seconds timeout * Change timeout to 180 sec, add error message * Update error message * Add unit test for timeout error
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Jan 7, 2021
…r-elasticsearch#284) * Add mutex to lock on creating report using puppeteer * Use semaphore instead of mutex * change semaphore limit to 1 * Add 30 seconds timeout * Change timeout to 180 sec, add error message * Update error message * Add unit test for timeout error
zhongnansu
pushed a commit
that referenced
this pull request
Jan 7, 2021
* Add mutex to lock on creating report using puppeteer * Use semaphore instead of mutex * change semaphore limit to 1 * Add 30 seconds timeout * Change timeout to 180 sec, add error message * Update error message * Add unit test for timeout error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.