This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Updated Time Range Parsing in Report Details #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
reviewed
Nov 13, 2020
kibana-reports/public/components/main/report_details/report_details.tsx
Outdated
Show resolved
Hide resolved
joshuali925
approved these changes
Nov 19, 2020
| let timeStringRegex = /time:\(from:.*,to:.*\)/; | ||
|
|
||
| let timeStringRegexArray = timeStringRegex.exec(queryUrl); | ||
| let timeString = timeStringRegexArray[0]; |
There was a problem hiding this comment.
just a note, you can probably do const [timeString, fromDateString, toDateString] = queryUrl.match(/time:\(from:(.+),to:(.+?)\)/) might be easier
also I think the lazy match in to:.*?\) is necessary? wouldn't to:.*\) match to the last )?
There was a problem hiding this comment.
Good catch - will make change
zhongnansu
approved these changes
Nov 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Time range in Report Details for
VisualizationsandSaved searchesfrom in-context menu would show as undefined. Updated the parsing so it displays correctly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.