This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
remove create report logic for background job #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| } | ||
| // TODO: generate report logic will be added back once we have the user impersonation | ||
| // if (reportSource === REPORT_TYPE.savedSearch) { |
There was a problem hiding this comment.
Do we need to leave this commented-out code in?
There was a problem hiding this comment.
Yes I leave it on purpose, once we have user impersonation added, this code snippet will be reused.
davidcui1225
approved these changes
Nov 13, 2020
akbhatta
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Since we don't have user impersonation now, and we only send a link instead of actual file by email, I remove the logic which causing error when security is enabled
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.