This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Fixed Base Url Formation for Visualizations/Saved Searches #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbhatta
approved these changes
Nov 13, 2020
zhongnansu
reviewed
Nov 13, 2020
...lic/components/report_definitions/report_settings/__tests__/report_settings_helpers.test.tsx
Outdated
Show resolved
Hide resolved
zhongnansu
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The
base_urlfield was not being formed correctly forVisualizationandSaved searchreport definitions, but has been fixed.getVisualizationBaseUrlCreateandgetSavedSearchBaseUrlCreateboth now take in theeditDefinitionIdas a parameter to replace that part of the url correctly. Test cases were also updated.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.