Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Add unit testing for model converters #182

Merged
merged 4 commits into from
Nov 11, 2020

Conversation

zhongnansu
Copy link
Member

Issue #, if available:

Description of changes:

  • Add unit testing for model converters
  • decouple code from helpers.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhongnansu zhongnansu marked this pull request as ready for review November 11, 2020 19:49
Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- please address comments before merging

@zhongnansu zhongnansu merged commit df71743 into opendistro-for-elasticsearch:dev Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants