This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Migrate create_report/ to Typescript #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirsoni
reviewed
Jun 17, 2020
seraphjiang
approved these changes
Jun 18, 2020
zhongnansu
reviewed
Jun 19, 2020
mihirsoni
suggested changes
Jun 21, 2020
Comment on lines
40
to
51
| const [reportSettingsDashboard, setReportSettingsDashboard] = useState(''); | ||
| const [deliveryEmailSubject, setDeliveryEmailSubject] = useState(''); | ||
| const [deliveryEmailBody, setDeliveryEmailBody] = useState(''); | ||
| const [scheduleRadioFutureDateSelected, setScheduleRadioFutureDateSelected] = useState(false); | ||
| const [scheduleRadioRecurringSelected, setScheduleRadioRecurringSelected] = useState(false); | ||
| const [scheduleUTCOffset, setScheduleUTCOffset] = useState(0); | ||
| const [scheduleFutureDate, setScheduleFutureDate] = useState(moment()); | ||
| const [scheduleRecurringFrequency, setScheduleRecurringFrequency] = useState('Daily'); | ||
| const [scheduleRecurringUTCOffset, setScheduleRecurringUTCOffset] = useState(0); | ||
| const [scheduleRecurringWeeklyDayOfWeek, setScheduleRecurringWeeklyDayOfWeek] = useState('Monday'); | ||
| const [scheduleRecurringStartDate, setScheduleRecurringStartDate] = useState(moment()); | ||
| const [scheduleRadioIdSelected, setScheduleRadioIdSelected] = useState(`${idPrefix}7`); |
There was a problem hiding this comment.
Use can also use useState with object. Such as
const reportState = useState<CreateReportState>({
....otherstates.
})
There was a problem hiding this comment.
Would I be defining the other states in CreateReportState? Otherwise I don't think I fully understand the added benefit
There was a problem hiding this comment.
Correct you can create a State which contains all the required info and move this inside une useState. to simplify
mihirsoni
reviewed
Jun 26, 2020
| { value: -10, text: 'HST -10:00' } | ||
| ]; | ||
|
|
||
| const ScheduleFutureDatePicker = () => { |
There was a problem hiding this comment.
You could move all individual components out to simplify and better readability.
mihirsoni
approved these changes
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#7
Description of changes:
Migrate all files in
create_report/to Typescript. All UI will be migrated to Typescript after this PR and #14 are merged.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.