Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

[Fix] Configure fixed timezone for jest testing #163

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Oct 29, 2020

Issue #, if available:
github action CI has test failures, while local testing is fine. It's due to github action is using UTC as timezone, while our testing is using America/Los_Angeles

Description of changes:

  • Configure fixed timezone for snapshot jest testing
  • All tests are passed now
    image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhongnansu zhongnansu added build Issue and question regarding plugin build test test labels Oct 29, 2020
Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongnansu zhongnansu changed the title [Bug Fix] Configure fixed timezone for jest testing [Fix] Configure fixed timezone for jest testing Oct 29, 2020
Copy link
Contributor

@abbashus abbashus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zhongnansu zhongnansu merged commit f718c48 into opendistro-for-elasticsearch:dev Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Issue and question regarding plugin build test test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants