[Testing] Update existing visual/data report helper test suite #157
Conversation
zhongnansu
requested review from
joshuali925,
abbashus,
davidcui1225 and
akbhatta
| @@ -9,12 +9,14 @@ | |||
| "module": "commonjs", | |||
| "outDir": "./target", | |||
| "noEmit": true, | |||
| "types": ["node", "jest", "react"], | |||
There was a problem hiding this comment.
Are these not needed? I thought this line had to be included
There was a problem hiding this comment.
Deleting this line will get rid of the type error on jest related types, such as describe(), test, jest.fn(). I am not sure about other negative affects, any idea?
There was a problem hiding this comment.
Do tests pass when you run yarn test --coverage? Aside from the ones that haven't been updated.
There was a problem hiding this comment.
I think there are existing snapshot tests that are not fixed yet
There was a problem hiding this comment.
Ok- should be fine then. It'll be an easy one-line fix if it does end up breaking anything, anyway 👍
|
Added one more line in |
Issue #, if available:
Description of changes:
Due to the previous code changes, need update existing test suites accordingly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.